Skip to content

Add ChangeRefCellDerefToNotExpression code fixer#10469

Merged
cartermp merged 4 commits intodotnet:mainfrom
cartermp:ref-cell-to-not
Nov 17, 2020
Merged

Add ChangeRefCellDerefToNotExpression code fixer#10469
cartermp merged 4 commits intodotnet:mainfrom
cartermp:ref-cell-to-not

Conversation

@cartermp
Copy link
Copy Markdown
Contributor

Another common new user mistake - using ! to negate an expression, now with a quick fix to along with the improved error message:

image

image

@cartermp
Copy link
Copy Markdown
Contributor Author

This is ready for review.

@cartermp cartermp requested a review from dsyme November 16, 2020 03:30
@cartermp
Copy link
Copy Markdown
Contributor Author

An alternative approach could be to nix the compiler API and just loop back through the range until a '!' is found. Simpler but maybe not technically pure

@cartermp cartermp closed this Nov 17, 2020
@cartermp cartermp reopened this Nov 17, 2020
@cartermp
Copy link
Copy Markdown
Contributor Author

re-opening because of nuget download failure in CI

@cartermp cartermp merged commit 66a88c1 into dotnet:main Nov 17, 2020
@cartermp cartermp deleted the ref-cell-to-not branch November 17, 2020 21:42
@cartermp cartermp added this to the 16.9 milestone Nov 17, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Add ChangeRefCellDerefToNotExpression code fixer

* Area
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
* Add ChangeRefCellDerefToNotExpression code fixer

* Area
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
* Add ChangeRefCellDerefToNotExpression code fixer

* Area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants