Prepare to ship FCS 39.0.0-preview #10584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the version number required us going to have to be 39, because there are a number of public surface area changes already in main from the 38 release. I know that the reactor thread changes are in there, for example. |
Member
|
Also, for this release could the MSBuild dependencies get added to the nuspec? It's a pretty prevalent gotcha that's hit several other consumers (including sharplab and xunit). If that dependency gets extracted later then it can just be removed from the nuspec. |
Contributor
Author
KevinRansom
changed the title
KevinRansom
force-pushed
the
resetFSharpCorePsckageVersion
branch
from
35a597b to
46c464f
Compare
cartermp
reviewed
Dec 3, 2020
Contributor
Author
brettfo
suggested changes
Dec 4, 2020
brettfo
approved these changes
Dec 7, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Prepare to ship fcs 39.0.0-preview- * feedback * Update Versions.props Oops bad merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare to ship fcs 39.0.0-preview
Reset FSharp.Core package version back to 5.0.0 because thats what shipped and set fcs version to 38.0.1