Set: Optimize away isinst check
#10860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store height in leaves. Compared to the old discussion, when Left/Right were proposed to be stored in a universal node, this adds 4 bytes to leaves or 2 bytes per item on average (vs 16/8).
`Match` produces `sub 1` and `switch` instruction. Here, for any non-trivial count, nodes are more frequent than leaves on the path, so branch prediction should be beneficial.
Contributor
|
@buybackoff No worries, we'll figure out the right merge strategy. I believe that because the changes are the same, it shouldn't matter if we take them independently. |
cartermp
approved these changes
Jan 12, 2021
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Changes look good for set too (I mean, they're the same, but hey, looks good!)
Contributor
|
@dsyme if you could take a look here as well that would be great. @buybackoff just FYI - in case this does take time to merge - we have a policy of two approvals required for PRs. We relax that a bit when the changes are straightforward and/or tiny, but this will require two sign-offs to proceed since it affects such a core set of data structures. |
KevinRansom
approved these changes
Jan 15, 2021
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #10845
If OK, this PR includes the Map changes. The Map one could be closed and this merged, or will rebase.