Skip to content

Prevent tests from attempting to write to C:\Windows\System32 #10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 2 commits into from
Jan 30, 2021
Merged

Prevent tests from attempting to write to C:\Windows\System32 #10888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5aaab5
Prevent tests from attempting to write to C:\Windows\System32
ScottHutchinson Jan 17, 2021
110ed5f
Add open System.Reflection
ScottHutchinson Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/FSharp.Test.Utilities/TestFramework.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ module TestFramework
open Microsoft.Win32
open System
open System.IO
open System.Reflection
open System.Text.RegularExpressions
open System.Diagnostics
open Scripting
Expand Down Expand Up @@ -55,8 +56,17 @@ module Commands =
else
p.WaitForExit()
#if DEBUG
File.WriteAllLines(Path.Combine(workingDir, "StandardOutput.txt"), outputList)
File.WriteAllLines(Path.Combine(workingDir, "StandardError.txt"), errorsList)
let workingDir' =
if workingDir = ""
then
// Assign working dir to prevent default to C:\Windows\System32
let executionLocation = Assembly.GetExecutingAssembly().Location
Path.GetDirectoryName executionLocation
else
workingDir

File.WriteAllLines(Path.Combine(workingDir', "StandardOutput.txt"), outputList)
File.WriteAllLines(Path.Combine(workingDir', "StandardError.txt"), errorsList)
#endif
p.ExitCode, outputList.ToArray(), errorsList.ToArray()
| None -> -1, Array.empty, Array.empty
Expand Down