[VS] Partial implementation of Go to definition for external IL symbols #10956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
approved these changes
Jan 27, 2021
| (projectInfo, documentInfo) | ||
|
|
||
| let DecompileCSharp (symbolFullTypeName: string, assemblyLocation: string) = | ||
| let logger = new StringBuilder(); |
| // Try to decompile; if an exception is thrown the caller will handle it | ||
| let mutable text = decompiler.DecompileTypeAsString(fullTypeName) | ||
|
|
||
| text <- text + "#if false // " + Environment.NewLine |
Contributor
There was a problem hiding this comment.
better without mutable, use let text = text + ...
| let mutable hierarchy = Unchecked.defaultof<_> | ||
| let mutable itemId = Unchecked.defaultof<_> | ||
| let mutable windowFrame = Unchecked.defaultof<_> | ||
| openDocumentService.OpenDocumentViaProject(filePath, ref VSConstants.LOGVIEWID.TextView_guid, &localServiceProvider, &hierarchy, &itemId, &windowFrame) |> ignore |
Contributor
There was a problem hiding this comment.
Can you use output tuples?
let _, localServiceProvider, hierarchy, itemId, windowFrame = openDocumentService.OpenDocumentViaProject(filePath, ref VSConstants.LOGVIEWID.TextView_guid)
| projectContext.DisplayName <- projInfo.Name | ||
| projectContext.AddSourceFile(docInfo.FilePath, sourceCodeKind = SourceCodeKind.Regular) | ||
|
|
||
| projInfo.MetadataReferences |
Contributor
Is there a way to make this happen? We do support navigating to C# symbols in a referenced project, so in theory we might have the tools needed to navigate |
cartermp
reviewed
Jan 27, 2021
|
|
||
| SourceText.From(text) | ||
|
|
||
| let ShowDocument (filePath, name, serviceProvider: IServiceProvider) = |
|
|
||
| (projectInfo, documentInfo) | ||
|
|
||
| let DecompileCSharp (symbolFullTypeName: string, assemblyLocation: string) = |
| open ICSharpCode.Decompiler.CSharp.Transforms | ||
| open ICSharpCode.Decompiler.TypeSystem | ||
|
|
||
| let GenerateTemporaryCSharpDocument (asmIdentity: AssemblyIdentity, name: string, metadataReferences) = |
| let! location = symbol.Locations |> Seq.tryHead | ||
| return (FSharpGoToDefinitionNavigableItem(project.GetDocument(location.SourceTree), location.SourceSpan), idRange) | ||
| let projectOpt = originDocument.Project.Solution.Projects |> Seq.tryFind (fun p -> p.AssemblyName.Equals(assembly, StringComparison.OrdinalIgnoreCase)) | ||
| if projectOpt.IsSome then |
KevinRansom
approved these changes
Jan 27, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…ls (dotnet#10956) * Initial commit * Openining document, but incorrect project association * Partial implementation for go-to-def of external symbols * Feedback
Contributor
|
Looks like you've missed a few piece But at least his is great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implementation that allows go-to-definition on external IL symbols by generating metadata source files; currently only generating "C#" metadata code.
This is partial, meaning that it doesn't generate a proper metadata-as-source C# file as it is missing formatting and doesn't navigate to the given symbol. We also can't do go-to-def on external "F#" symbols yet.
Roslyn has internal services that could help with the formatting, but there must be additions to F#'s external access in order to take advantage of it.
I thought about re-using Roslyn's whole metadata-as-source implementation by adding a F# external access API, but we really can't use the API as it relies on
ISymbol. See here: http://sourceroslyn.io/#Microsoft.CodeAnalysis.Features/MetadataAsSource/IMetadataAsSourceFileService.cs,25