SyntaxTree: always keep parsed implicit constructors #10967
Conversation
auduchinok
changed the title
auduchinok
changed the title
|
It's ready. |
|
Thanks! |
|
|
||
| // Process a class declaration or F# type declaration | ||
| let rec walkTycon (TypeDefn(ComponentInfo(_, _, _, _, _, _, _, _), repr, membDefns, m)) = | ||
| let rec walkTycon (TypeDefn(ComponentInfo(_, _, _, _, _, _, _, _), repr, membDefns, _, m)) = |
There was a problem hiding this comment.
This should walk the implicit ctor if it's there
There was a problem hiding this comment.
I expect it to walk in it for object model types if it already does (via repr members), this behaviour hasn't changed. Do you mean it should walk in it for types that don't allow implicit constructors too? This PR only adds possibly thrown out constructors back, so it's possible to inspect them via syntax tree inside non-object model types too (via a separate field that is ignored by the type checker).
| | SynTypeDefnSigRepr.Exception(_) -> None | ||
|
|
||
| and walkTypeDefn (TypeDefn (info, repr, members, _)) = | ||
| and walkTypeDefn (TypeDefn (info, repr, members, _, _)) = |
There was a problem hiding this comment.
This should walk the implicit ctor if it's there
| processExnDefnRepr baseName nested repr | ||
|
|
||
| and processTycon baseName (TypeDefn(ComponentInfo(_, _, _, lid, _, _, access, _), repr, membDefns, m)) = | ||
| and processTycon baseName (TypeDefn(ComponentInfo(_, _, _, lid, _, _, access, _), repr, membDefns, _, m)) = |
There was a problem hiding this comment.
This should walk the implicit ctor if it's there?
| | SynModuleDecl.Open _ -> () | ||
|
|
||
| and walkSynTypeDefn(TypeDefn(componentInfo, representation, members, _)) container = | ||
| and walkSynTypeDefn(TypeDefn(componentInfo, representation, members, _, _)) container = |
There was a problem hiding this comment.
This should walk the implicit ctor if it's there
| None | ||
|
|
||
| and walkSynTypeDefn(TypeDefn(_componentInfo, representation, members, range)) = | ||
| and walkSynTypeDefn(TypeDefn(_componentInfo, representation, members, _, range)) = |
There was a problem hiding this comment.
This should walk the implicit ctor if it's there
| | SynTypeDefnSigRepr.Exception _ -> () | ||
|
|
||
| and walkTypeDefn (TypeDefn (info, repr, members, _)) = | ||
| and walkTypeDefn (TypeDefn (info, repr, members, _, _)) = |
There was a problem hiding this comment.
This should walk the implicit ctor if it's there
3 participants
Keeps parsed implicit constructors for types that are not allowed to have them in the syntax tree.