Fix #11143 - FSharp.Core 5.0.1 should not have FSharp.Core.xml in contentFiles#11160
Merged
cartermp merged 1 commit intodotnet:mainfrom Mar 2, 2021
Merged
Fix #11143 - FSharp.Core 5.0.1 should not have FSharp.Core.xml in contentFiles#11160cartermp merged 1 commit intodotnet:mainfrom
cartermp merged 1 commit intodotnet:mainfrom
Conversation
TIHan
approved these changes
Mar 2, 2021
brettfo
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11143 - FSharp.Core 5.0.1 should not have FSharp.Core.xml in contentFiles
The FSharp.Core nuget package has been updated to carry FSharp.Core.xml as content, which enables the build to pick it up for tools that want to show help messages for API's.
Content files from nuget packages are automatically referenced which is somewhat unfortunate for FSharp.Core, where the overwhelming majority of apps will not want to redistribute that file.
This change makes including FSharp.Core.xml in build output opt-in.
To ensure that FSharp.Core.xml is included in the distributed app, add this to a PropertyGroup in the build project: