Optimize PreComputeTupleConstructor #11230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against
There's one little problem though. When values of the wrong type are passed to the precomputed constructor,
InvalidCastExceptionis now thrown instead ofArgumentException(MakeTuplestill throws this as well). I'm not sure if this matters that much (I suspect a similar change sneaked into #9784), but if it does, I could theoretically emit a runtime check throwing the old exception here at the cost of a small performance hit.