ByteBuffer uses ArrayPool to prevent LOH allocations
#11660
Conversation
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
I like the approach, and it seems great to not constantly reallocate those large buffers.
TIHan
changed the title
TIHan
changed the title
ByteBuffer uses ArrayPool to prevent LOH allocations
TIHan
changed the title
ByteBuffer uses ArrayPool to prevent LOH allocationsByteBuffer uses ArrayPool to prevent LOH allocations
eng/Versions.props
Outdated
| https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json; | ||
| </RestoreSources> | ||
| <!-- System.* packages --> | ||
| <SystemRuntimeCompilerServicesUnsafeVersion>4.7.1</SystemRuntimeCompilerServicesUnsafeVersion> |
There was a problem hiding this comment.
@KevinRansom you may not like this, but the changes I made with the ByteBuffer, is calling something from System.Runtime.CompilerServices.Unsafe, which has problems with binding redirects. Best way to resolve this is including the specific version.
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
This looks goods, I wonder why we have so many different sizes for allocation buffers, 100000, 50000, 20000 and 10000. Meaningful names might help me understand why each size was chosen, Of course it might not too.
src/fsharp/QuotationPickler.fs
Outdated
| let phase2data = (stringTab, phase1bytes) | ||
|
|
||
| let st2 = | ||
| { os = ByteBuffer.Create(100000, useArrayPool = true) |
There was a problem hiding this comment.
possibly a constant for 100000, it's used several places in this code.
There was a problem hiding this comment.
I have no idea why these values were chosen. This was here before.
There was a problem hiding this comment.
Yeah, just give it a name. pickle_object_buffersize or somesuch.
There was a problem hiding this comment.
I added the literals.
src/fsharp/absil/ilwrite.fs
Outdated
| requiredDataFixups= requiredDataFixups | ||
| requiredStringFixups = [] | ||
| codeChunks=ByteBuffer.Create 40000 | ||
| codeChunks=ByteBuffer.Create(40000, useArrayPool = true) |
There was a problem hiding this comment.
perhaps constant for 40000
src/fsharp/absil/ilwrite.fs
Outdated
| codedBigness 2 TableNames.TypeRef | ||
|
|
||
| let tablesBuf = ByteBuffer.Create 20000 | ||
| use tablesBuf = ByteBuffer.Create(20000, useArrayPool = true) |
There was a problem hiding this comment.
perhaps a name and a constant for 20000
src/fsharp/absil/ilwrite.fs
Outdated
|
|
||
| let metadata, guidStart = | ||
| let mdbuf = ByteBuffer.Create 500000 | ||
| use mdbuf = ByteBuffer.Create(500000, useArrayPool = true) |
There was a problem hiding this comment.
Perhaps a name and a constant for 50000?
|
Addresses this issue: #7982 |
|
note that azdo is down for us, so there's no point in trying to re-trigger CI |
4 participants
We allocate a lot on the LOH when serializing FSharp metadata. This PR should help.