[RFC FS-1107] Allow attributes after the 'module' keyword #11722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I... have zero idea about how to proceed. |
vzarytovskii
requested review from
KevinRansom,
TIHan and
dsyme
and removed request for
dsyme
dsyme
reviewed
Jun 29, 2021
| //------------------------------------------------------------------------ | ||
|
|
||
| let ParseAssemblyCodeInstructions s reportLibraryOnlyFeatures (isFeatureSupported: LanguageFeature -> bool) m : IL.ILInstr[] = | ||
| let ParseAssemblyCodeInstructions s reportLibraryOnlyFeatures (isFeatureSupported: LanguageFeature -> bool) checkLanguageFeatureErrorRecover m : IL.ILInstr[] = |
Contributor
There was a problem hiding this comment.
There's something weird with file ordering that we need to pass these function parameters. It's sort of of orthogonal to the PR however, so we can clean it up separately.
dsyme
reviewed
Jun 29, 2021
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Thank you for the very extensive testing, very good!
dsyme
approved these changes
Jun 29, 2021
vzarytovskii
approved these changes
Jun 29, 2021
dsyme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/fsharp/fslang-design/blob/main/preview/FS-1107-Allow-attributes-after-the-module-keyword.md
fsharp/fslang-suggestions#757