use path separator instead of hardcoded semicolon #11730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
suggested changes
Jun 25, 2021
baronfel
force-pushed
the
depmanager-path-handling
branch
from
dca8ebe to
93c9c68
Compare
brettfo
approved these changes
Jun 25, 2021
auto-merge was automatically disabled
June 25, 2021 19:23
Head branch was pushed to by a user without write access
baronfel
force-pushed
the
depmanager-path-handling
branch
from
93c9c68 to
176aabb
Compare
Member
Author
|
|
baronfel
force-pushed
the
depmanager-path-handling
branch
from
176aabb to
8abfea1
Compare
vzarytovskii
approved these changes
Jun 28, 2021
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Contributor
|
Thank you, I didn't know about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #11729, but we'll see what CI has to say about it.