Added script reference test and clearing check file caches on re-created incremental build #11731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@TIHan Could you please add an FCS test too? |
Contributor
Author
|
Yes, I will try to add one. |
dsyme
approved these changes
Jun 29, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…ted incremental build (dotnet#11731) * Added script referencing dll test in WorkspaceTests, but failing * Clear check file caches associated with a re-created incremental build * Minor comment update * Minor comment update * Forgot to delete dll in test * Remove ignore * Using defaultTimeStamp instead of DateTime.MinValue * Added FCS test * Minor update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a single test to
WorkspaceTeststhat tests whether or not the script will update properly when a DLL file that it is referencing changes.When first writing the test, it was failing because FCS was returning back cached/stale check file results even after the incremental build was re-created when one of its references changed. Clearing the items associated with the project in the cache fixed this issue.
What caused the issue in the first place, wasn't necessarily due to not clearing any caches, but because I made a change where the first file was returning
DateTime.MinValueinstead of thedefaultTimeStampwhich gets set toDateTime.UtcNowwhen an incremental build gets created. I made an additional change to return thedefaultTimeStamp.