apply source-build patches #11762
Merged
apply source-build patches #11762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@crummel, Can you please review since you were the original patch author. |
crummel
approved these changes
Jul 1, 2021
Contributor
crummel
left a comment
crummel
left a comment
There was a problem hiding this comment.
Yes, this should be fine. I believe the original issue was caused by some missing ref packages in SBRP which are now fixed.
vzarytovskii
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the source-build patches to
main.@MichaelSimons The patch "updated" FSharp.Compiler.Service.fsproj by hard-coding the package versions, but those version numbers were exactly what we already had in
eng/Versions.props; was this really a meaningful change that needs to be preserved? My understanding is that all package version numbers should come fromeng/Versions.propswhenever possible, and not be hard-coded in a project file.Otherwise the changes to the other two files were applied, with fsc.fsproj using the variable from
eng/Versions.props.Fixes #11435.