Remove call to SetLength when copying ReadOnlyMemory<byte> to a MemoryMapped file
#11796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Jul 8, 2021
| stream.SetLength(stream.Length + length) | ||
| let span = Span<byte>(stream.PositionPointer |> NativePtr.toVoidPtr, int length) | ||
| bytes.Span.CopyTo(span) | ||
| stream.Position <- stream.Position + length |
Member
There was a problem hiding this comment.
Do we still need to set the position here too?
Contributor
Author
There was a problem hiding this comment.
Yea as TryFromByteMemory version does not reset the stream's position once it's copied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vzarytovskii correctly pointed out that we can't set the length of a memory mapped file. It's already fixed length so it should be safe to not do it.