Cleanup and document async.fs #11806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of fixing bug #11797 via #11799 made me go back and review async.fs end-to-end.
This does the following:
Very carefully documenting exactly when cancellation and trampoline/hijack checks are currently made
Fix Should
async.TryFinallyregister thefinallyblock before checking for cancellation? #8675, where a cancellation check was happening before a try/finally was being entered, causing resources to be potentially dropped on the floor if cancellation happensCleanup the code that does CancellationTokenRegistration (AwaitWaitHandle, AwaitBeginEnd etc.) to be more uniform