-
Notifications
You must be signed in to change notification settings - Fork 847
Warn unsupported attributes #11812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn unsupported attributes #11812
Conversation
|
Need to fix up the test and get it green, but this is great, thank you. |
|
@dsyme, I'm wondering if this should be an error, because if we should ever choose to implement the functionality declared by these attributes then it would be a breaking change. |
|
@KevinRansom Making it an error where it'd previously compile fine would be a breaking change itself. |
| |> FSharp | ||
| |> typecheck | ||
| |> shouldFail | ||
| |> withResults [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note - a less verbose withDiagnostics can be used here, for example, like in the ErrorMessages suite:
| |> withDiagnostics [ | |
| (Error 767, Line 8, Col 16, Line 8, Col 23, "The type Foo contains the member 'MyX' but it is not a virtual or abstract method that is available to override or implement.") | |
| (Error 17, Line 8, Col 18, Line 8, Col 21, "The member 'MyX : unit -> int' does not have the correct type to override any given virtual method") | |
| (Error 783, Line 6, Col 11, Line 6, Col 14, "At least one override did not correctly implement its corresponding abstract member")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vzarytovskii How can I generate them? For withResults I can just copy from the test output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vzarytovskii How can I generate them? For
withResultsI can just copy from the test output.
I'm afraid, you'll have to write them manually :(
Let me see if I can serialise them into something which you can just copy-paste into withDiagnostics.
No description provided.