Fix tailcalls in async.fs #11820
Merged
Fix tailcalls in async.fs #11820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 9, 2021 01:19
TIHan
approved these changes
Jul 14, 2021
Contributor
Author
|
I'll add testing for this separately, since we have nothing to check we won't regress it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11807 showed up a bug in async.fs where tailcalls are not being taken, making the use of the trampoline necessary.
We should take tailcalls in any case to keep stack sizes small, this is the fix to make sure we do
I'll have a think how to test this, and also re-run 11807 to check if tests then pass