Fix ranges of function applications in Release code #11827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
dsyme
changed the title
Contributor
Author
|
This is ready (it's simple enough and has already been reviewed) |
dsyme
force-pushed
the
revert-11792-revert-11717-db6
branch
from
0171033 to
15321c2
Compare
Contributor
Author
|
@vzarytovskii @KevinRansom @TIHan Can you approve? thanks will help with another integration I have |
vzarytovskii
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reinstate a trimmed down version of #11717 which was reverted in #11792
The original PR contained several improvements to debugging ranges for function applications in release code, but the overall "headline" item of avoiding remarking of
inlineand Release-mode code didn't work like I'd hoped so that change got reverted (it gave good improvements to breakpoints but degraded typical call stacks).This reinstates the range fixes in the original PR