Skip to content

Minor test namespace refactor #11836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vzarytovskii merged 2 commits into from
Jul 16, 2021
Merged

Minor test namespace refactor #11836

vzarytovskii merged 2 commits into from
Jul 16, 2021

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Jul 15, 2021 •
edited
Loading

Whilst investigating a CI issue, I noticed that we use getTestDirectory from tests.fs in a bunch of the new test framework tests cases.

This refactor breaks that dependence.

  • moves the FSharp.Tests.Utilities namespace up to FSharp.Tests
  • adds to FSharp.Tests.Utilities.Utilities the getTestDirectory function

@KevinRansom KevinRansom requested a review from vzarytovskii July 15, 2021 20:59
@KevinRansom KevinRansom changed the title Minor test namespace Minor test namespace refactor Jul 15, 2021
@vzarytovskii vzarytovskii merged commit fca1cd7 into dotnet:main Jul 16, 2021
@KevinRansom KevinRansom deleted the minorrefactor branch January 21, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KevinRansom @vzarytovskii