Parser: better tree for unfinished paren patterns #12065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
changed the title
Member
Author
|
|
auduchinok
changed the title
auduchinok
force-pushed
the
parser-parenPat
branch
from
3c20801 to
1ad32fe
Compare
auduchinok
force-pushed
the
parser-parenPat
branch
from
1ad32fe to
6d5a1a6
Compare
Member
Author
|
This is ready (again). |
dsyme
added
the
Theme-Simple-F#
dsyme
reviewed
Aug 31, 2021
| [<Test>] | ||
| let ``Let - Parameter - Paren 02 - Tuple`` () = | ||
| let parseResults = getParseResults """ | ||
| let f (x, y |
Contributor
There was a problem hiding this comment.
Can you add a test for
let f (x,
thanks
Contributor
There was a problem hiding this comment.
Also maybe
match () with
| (x,
| _ -> ()
and
match () with
| (x
| _ -> ()
TIHan
approved these changes
Sep 2, 2021
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
Looks good to me, should make tooling better in this area for everyone :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following examples
(parens orstruct (were ignored:PR makes it properly produce paren patterns.