Fix 12085 #12095
Merged
Fix 12085 #12095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Will this make it to the 6.0 release? |
Contributor
Author
|
This should also go into release/dev17.0 (if we're not merging main across automatically) |
Contributor
Author
Yes I believe so |
TIHan
reviewed
Sep 2, 2021
| /// We can't tailcall to methods taking byrefs. This helper helps search for them | ||
| let IsILTypeByref = function ILType.Byref _ -> true | _ -> false | ||
| let rec IsILTypeByref inp = | ||
| match inp with |
Contributor
There was a problem hiding this comment.
Later we should use stripILModifiedFromTy :
match stripILModifiedFromTy inp with
| ILType.Byref _ -> true
| _ -> false
TIHan
approved these changes
Sep 2, 2021
Contributor
Author
|
@TIHan We should scan the whole codebase for pattern matchin on ILType |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12085