Samples for seq module #12133
Samples for seq module #12133
Conversation
|
|
|
I did this for this one #12124, I took from the top instead of the bottom. My bad |
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Great work! Some initial feedback
src/fsharp/FSharp.Core/seq.fsi
Outdated
| /// | ||
| /// <example> | ||
| /// <code lang="fsharp"> | ||
| /// [(fun () -> Seq.ofList [1; 2; 3]) |> Seq.delay // evaluates to seq [1; 2; 3], calling the gnerator every time. |
There was a problem hiding this comment.
Extra leading [
You wouldn't use pipelining with Seq.delay
There was a problem hiding this comment.
I'll change, but would like to know why, if you don't mind. (as in: I want to learn more)
|
@JYCabello I made one update - we can merge this when it's green On re-read the compareWith examples could perhaps be better - they currently use the default comparison semantics for integers - we should change to examples which say compare the number |
Will do on the next PR. |
|
Great work @JYCabello, thank you so much for this contribution. |
3 participants
Just to have some early feedback, or merge if it's OK.