Disable apphost on downlevel frameworks during source-build#12286
Merged
Conversation
During source-build, disable apphost build for 'fsi' and 'fsc', and 'fsyacc', 'fslex', and 'AssemblyCheck' during the bootstrap build. Creating an apphost for a net5.0 project while building with a net6.0 SDK downloads the apphost pack as a prebuilt. Stopping the projects from creating the apphost removes the prebuilt for source-build. To make disabling the apphost work in the bootstrapping build, add a check to eng/build.sh to skip the bootstrap build if we're currently running the "outer" source-build. That gives source-build the ability to run bootstrapping on its own terms. Now, when eng/SourceBuild.props runs bootstrapping, it can pass the DotNetBuildFromSource property through the environment so it takes effect.
brettfo
reviewed
Oct 27, 2021
| # and building bootstrap needs to wait. The source-build targets will run this | ||
| # script again without setting source_build=true when it is done setting up | ||
| # the build environment. See 'eng/SourceBuild.props'. | ||
| if [[ "$source_build" != true ]]; then |
Member
There was a problem hiding this comment.
I presume the source_build environment variable is set prior to running this?
brettfo
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During source-build, disable apphost build for 'fsi' and 'fsc', and
'fsyacc', 'fslex', and 'AssemblyCheck' during the bootstrap build.
Creating an apphost for a net5.0 project while building with a net6.0
SDK downloads the apphost pack as a prebuilt. Stopping the projects from
creating the apphost removes the prebuilt for source-build.
To make disabling the apphost work in the bootstrapping build, add a
check to eng/build.sh to skip the bootstrap build if we're currently
running the "outer" source-build. That gives source-build the ability to
run bootstrapping on its own terms. Now, when eng/SourceBuild.props runs
bootstrapping, it can pass the DotNetBuildFromSource property through
the environment so it takes effect.
fscandfsiduring source-build #12282I've run this through a source-build tarball build locally and it seems to remove the prebuilt 5.0 apphost: dotnet/installer#12456.
/cc @dotnet/source-build-internal