Fixes #12732 - TypeLoadException debugging VisualFSharpDebug and #12855 - Can't properly debug VisualFSharpDebug configuration #12868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to newer completion external access API * Global options * GetRules * Update Roslyn to 4.1.0-1.21511.14 * Update VS packages * Fix * Fix
vzarytovskii
approved these changes
Mar 22, 2022
brettfo
approved these changes
Mar 22, 2022
Contributor
|
Thank you, looks good on my end! |
Contributor
|
Thank you @KevinRansom! |
Member
|
@KevinRansom Thank you for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12732
This was caused by a mismatch in the Roslyn shim: microsoft.codeanalysis.externalaccess.fsharp
The fix was already made in the dev17.2 branch, this just ports it back to main.