Filter type test completion list #12930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerams
commented
Apr 2, 2022
| | SynExpr.Match (expr=synExpr; clauses=synMatchClauseList) -> | ||
| [yield dive synExpr synExpr.Range traverseSynExpr | ||
| yield! synMatchClauseList |> List.map (fun x -> dive x x.RangeOfGuardAndRhs (traverseSynMatchClause path))] | ||
| yield! synMatchClauseList |> List.map (fun x -> dive x x.Range (traverseSynMatchClause path))] |
Contributor
Author
There was a problem hiding this comment.
I don't know why RangeOfGuardAndRhs was used here. MatchLambda and TryWith traversals use Range, so this change seemed appropriate. Without it VisitPat is never fired in a match clause pattern, and so we don't get a chance to create the right completion context.
kerams
commented
Apr 2, 2022
| match p with | ||
| | SynPat.Paren (p, _) -> traversePat path p | ||
| | SynPat.Or (p1, p2, _, _) -> [ p1; p2] |> List.tryPick (traversePat path) | ||
| | SynPat.As (p1, p2, _) |
Contributor
Author
There was a problem hiding this comment.
This looked like an omission. I don't see why we wouldn't want to dive into both subpatterns here. Without it VisitPat is not fired for IsInst when the type test is paired with an as (which it very often is).
Member
There was a problem hiding this comment.
completely agree with this logic
baronfel
approved these changes
Apr 15, 2022
vzarytovskii
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
pressing Ctrl-space on
strorArgwill now only show type-like completions. Currently the list also contains keywords and functions.