Skip to content

Fix for subtype pattern matching #13178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 2 commits into from
May 23, 2022
Merged

Fix for subtype pattern matching #13178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c946c8
tentative fix for pattern matching logic
dsyme May 23, 2022
c464767
add test matrix
dsyme May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Compiler/Checking/PatternMatchCompilation.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,7 +1495,7 @@ let CompilePatternBasic
[]

| DecisionTreeTest.IsNull _ ->
match computeWhatSuccessfulTypeTestImpliesAboutNullTest g tgtTy1 with
match computeWhatSuccessfulNullTestImpliesAboutTypeTest g tgtTy1 with
| Implication.Succeeds -> [Frontier (i, newActives, valMap)]
| Implication.Fails -> []
| Implication.Nothing -> [frontier]
Expand All @@ -1509,7 +1509,7 @@ let CompilePatternBasic

match discrim with
| DecisionTreeTest.IsInst (_srcTy, tgtTy2) ->
match computeWhatSuccessfulTypeTestImpliesAboutTypeTest g amap m tgtTy1 tgtTy2 with
match computeWhatSuccessfulTypeTestImpliesAboutTypeTest g amap m tgtTy2 tgtTy1 with
| Implication.Succeeds ->
match pbindOpt with
| Some pbind ->
Expand All @@ -1531,7 +1531,7 @@ let CompilePatternBasic
[frontier]

| DecisionTreeTest.IsNull _ ->
match computeWhatSuccessfulTypeTestImpliesAboutNullTest g tgtTy1 with
match computeWhatSuccessfulNullTestImpliesAboutTypeTest g tgtTy1 with
| Implication.Succeeds -> [Frontier (i, newActives, valMap)]
| Implication.Fails -> []
| Implication.Nothing -> [frontier]
Expand All @@ -1548,7 +1548,7 @@ let CompilePatternBasic
| DecisionTreeTest.IsNull ->
[Frontier (i, newActives, valMap)]
| DecisionTreeTest.IsInst (_, tgtTy) ->
match computeWhatSuccessfulNullTestImpliesAboutTypeTest g tgtTy with
match computeWhatSuccessfulTypeTestImpliesAboutNullTest g tgtTy with
| Implication.Succeeds -> [Frontier (i, newActives, valMap)]
| Implication.Fails -> []
| Implication.Nothing -> [frontier]
Expand Down
Loading