Skip to content

Workaround for emptying FSharp.Editor cache due to duplicate ProjectSystem events #13313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 3 commits into from
Jun 17, 2022
Merged

Workaround for emptying FSharp.Editor cache due to duplicate ProjectSystem events #13313

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dba993e
Workaroud for emptying FSharp.Editor cache due to duplicate PS events
vzarytovskii Jun 16, 2022
6168991
Update vsintegration/src/FSharp.Editor/LanguageService/LanguageServic…
vzarytovskii Jun 17, 2022
7c275e0
Update vsintegration/src/FSharp.Editor/LanguageService/LanguageServic…
vzarytovskii Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ type internal HackCpsCommandLineChanges
/// This handles commandline change notifications from the Dotnet Project-system
/// Prior to VS 15.7 path contained path to project file, post 15.7 contains target binpath
/// binpath is more accurate because a project file can have multiple in memory projects based on configuration
member _.HandleCommandLineChanges(path:string, sources:ImmutableArray<CommandLineSourceFile>, _references:ImmutableArray<CommandLineReference>, options:ImmutableArray<string>) =
member _.HandleCommandLineChanges(path:string, sources:ImmutableArray<CommandLineSourceFile>, references:ImmutableArray<CommandLineReference>, options:ImmutableArray<string>) =
use _logBlock = Logger.LogBlock(LogEditorFunctionId.LanguageService_HandleCommandLineArgs)

let projectId =
Expand All @@ -363,5 +363,11 @@ type internal HackCpsCommandLineChanges

let sourcePaths = sources |> Seq.map(fun s -> getFullPath s.Path) |> Seq.toArray

let workspaceService = workspace.Services.GetRequiredService<IFSharpWorkspaceService>()
workspaceService.FSharpProjectOptionsManager.SetCommandLineOptions(projectId, sourcePaths, options)
/// Due to an issue in project system, when we close and reopen solution, it sends the CommandLineChanges twice for every project.
/// First time it sends a correct path, sources, references and options.
/// Second time it sends a correct path, empty sources, empty references and empty options, and we rewrite our cache, and fail to colourize the document later.
/// As a workaround, until we have a fix from PS or will move to Roslyn as a source of truth, we will not overwrite the cache in case of empty lists.

if not (sources.IsEmpty && references.IsEmpty && options.IsEmpty) then
let workspaceService = workspace.Services.GetRequiredService<IFSharpWorkspaceService>()
workspaceService.FSharpProjectOptionsManager.SetCommandLineOptions(projectId, sourcePaths, options)