Skip to content

More tests for RFC FS-1126 Allow lowercase DU cases when RequireQualifiedAccess #13656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 1 commit into from
Aug 12, 2022
Merged

More tests for RFC FS-1126 Allow lowercase DU cases when RequireQualifiedAccess #13656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ....Compiler.ComponentTests/Conformance/UnionTypes/E_LowercaseWhenRequireQualifiedAccess.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,19 @@ type DU6 = a

type du1 = du1 of string

type du2 = | du2 of string
type du2 = | du2 of string

[<RequireQualifiedAccess>]
type du3 =
| a
| ``c``

[<RequireQualifiedAccess>]
type du4 =
| a
| ``a.b``

[<RequireQualifiedAccess>]
type du5 =
| a
| ``A.C``
14 changes: 14 additions & 0 deletions ...rp.Compiler.ComponentTests/Conformance/UnionTypes/LowercaseWhenRequireQualifiedAccess.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,27 @@ type DU2 =
| a of int
| B of string
| C
| ``D`` of bool
| ``d`` of string * int

[<RequireQualifiedAccess>]
type DU3 = | a

[<RequireQualifiedAccess>]
type DU4 = a

[<RequireQualifiedAccess>]
type DU5 = ``a``

[<RequireQualifiedAccess>]
type DU6 = ``A``

[<RequireQualifiedAccess>]
type DU7 = | ``a``

[<RequireQualifiedAccess>]
type DU8 = | ``A``

[<RequireQualifiedAccess>]
type du1 = du1 of string

Expand Down
9 changes: 9 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/Conformance/UnionTypes/UnionTypes.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,8 @@ module UnionTypes =
(Error 53, Line 18, Col 12, Line 18, Col 13, "Lowercase discriminated union cases are only allowed when using RequireQualifiedAccess attribute");
(Error 53, Line 20, Col 12, Line 20, Col 15, "Lowercase discriminated union cases are only allowed when using RequireQualifiedAccess attribute");
(Error 53, Line 22, Col 14, Line 22, Col 17, "Lowercase discriminated union cases are only allowed when using RequireQualifiedAccess attribute")
(Error 883, Line 32, Col 7, Line 32, Col 14, "Invalid namespace, module, type or union case name");
(Error 883, Line 37, Col 7, Line 37, Col 14, "Invalid namespace, module, type or union case name")
]

//SOURCE=E_LowercaseWhenRequireQualifiedAccess.fsx # E_LowercaseWhenRequireQualifiedAccess.fsx
Expand All @@ -565,6 +567,13 @@ module UnionTypes =
(Error 53, Line 18, Col 12, Line 18, Col 13, "Discriminated union cases and exception labels must be uppercase identifiers");
(Error 53, Line 20, Col 12, Line 20, Col 15, "Discriminated union cases and exception labels must be uppercase identifiers");
(Error 53, Line 22, Col 14, Line 22, Col 17, "Discriminated union cases and exception labels must be uppercase identifiers")
(Error 53, Line 26, Col 7, Line 26, Col 8, "Discriminated union cases and exception labels must be uppercase identifiers");
(Error 53, Line 27, Col 7, Line 27, Col 12, "Discriminated union cases and exception labels must be uppercase identifiers")
(Error 53, Line 31, Col 7, Line 31, Col 8, "Discriminated union cases and exception labels must be uppercase identifiers");
(Error 883, Line 32, Col 7, Line 32, Col 14, "Invalid namespace, module, type or union case name");
(Error 53, Line 32, Col 7, Line 32, Col 14, "Discriminated union cases and exception labels must be uppercase identifiers");
(Error 53, Line 36, Col 7, Line 36, Col 8, "Discriminated union cases and exception labels must be uppercase identifiers");
(Error 883, Line 37, Col 7, Line 37, Col 14, "Invalid namespace, module, type or union case name")
]

//SOURCE=W_GenericFunctionValuedStaticProp02.fs SCFLAGS="--test:ErrorRanges --warnaserror-" # W_GenericFunctionValuedStaticProp02.fs
Expand Down