Only add open path when module exposes types or bindings. #13764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
force-pushed
the
signature-types-in-shared-namespace
branch
from
6ed32ff to
4dc12be
Compare
nojaf
force-pushed
the
signature-types-in-shared-namespace
branch
from
4dc12be to
51478b6
Compare
dsyme
reviewed
Aug 23, 2022
Contributor
|
The fix seems strange. It feels like a reimplementation of isConcreteNamespace. But I need to look more carefully, just looking on my phone right now. |
Contributor
Author
|
Yes, I believe I can re-use |
dsyme
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #13761.