Fix 13805 #13815
Merged
Fix 13805 #13815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Are we in need of a new CI leg? |
Contributor
Author
I'm afraid arm and ci are not straightforward. |
0101
approved these changes
Sep 1, 2022
src/Compiler/AbstractIL/ilwrite.fs
Outdated
| | Some IA64 -> writeInt32AsUInt16 os 0x200 // Machine - IMAGE_FILE_MACHINE_IA64 | ||
| | Some ARM64 -> writeInt32AsUInt16 os 0xaa64 // Machine - IMAGE_FILE_MACHINE_ARM64 | ||
| | Some ARM -> writeInt32AsUInt16 os 0x1c0 // Machine - IMAGE_FILE_MACHINE_ARM | ||
| | Some ARM -> writeInt32AsUInt16 os 0x1c4 // Machine - IMAGE_FILE_MACHINE_ARM |
Contributor
There was a problem hiding this comment.
I don't really know anything about this, but according to this table this value is called IMAGE_FILE_MACHINE_ARMNT. So maybe update the comment to avoid possible future confusion :)
vzarytovskii
reviewed
Sep 1, 2022
vzarytovskii
added a commit
to vzarytovskii/fsharp
that referenced
this pull request
Sep 19, 2022
* Fix 13805 * Update src/Compiler/AbstractIL/ilwrite.fs Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
vzarytovskii
added a commit
that referenced
this pull request
Sep 19, 2022
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh my gosh ... this is embarrassing. Please forgive me, or at least beat me gently ...
When I added arm64 and arm native support to the F# compiler, I used the wrong value for MachineType.
it was specified as ARM (CE) for windows CE, rather than ARM.
Anyway, this PR fixes that.