Demo: of tweak to option parser to support OptionConsoleOnly with --langversion:? #13862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@psfinaki, @vzarytovskii - hey here is a very minor tweak, although it also includes an opportunistic name change of some local variables.
The basic idea is to split the option 's' into:
Then add a handler :
| CompilerOption (s, _, OptionConsoleOnly f, d, _) :: _ when option = s ->
reportDeprecatedOption d
f blocks
t
So when the handlers see the fully specified option:
langversion:?it handles it (show the langversion options), otherwise it falls through to the OptionUnit version which handles setting the value.If you like this approach just add this code to your PR or perhaps do something else similar, fix the text and tests and tidy up the code :-)
Kevin