Skip to content

Internal error in CheckExpressions.fs #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 4 commits into from
Sep 15, 2022
Merged

Internal error in CheckExpressions.fs #13894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4db0dd
add a guard that checks if the lenght of fittedArgs is accesible by i…
edgarfgp Sep 13, 2022
4c8579b
Merge branch 'main' into internal-error-check-expressions
vzarytovskii Sep 13, 2022
8ce29ad
Merge branch 'main' into internal-error-check-expressions
edgarfgp Sep 15, 2022
9ae1393
Merge branch 'main' into internal-error-check-expressions
KevinRansom Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Compiler/Checking/CheckExpressions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8262,8 +8262,9 @@ and TcUnionCaseOrExnCaseOrActivePatternResultItemThen (cenv: cenv) overallTy env
// first: put all positional arguments
let mutable currentIndex = 0
for arg in unnamedArgs do
fittedArgs[currentIndex] <- arg
currentIndex <- currentIndex + 1
if currentIndex < fittedArgs.Length then
fittedArgs[currentIndex] <- arg
currentIndex <- currentIndex + 1

let SEEN_NAMED_ARGUMENT = -1

Expand Down
4 changes: 3 additions & 1 deletion ...s/FSharp.Compiler.ComponentTests/Conformance/UnionTypes/E_UnionConstructorBadFieldName.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@ match y with
| Case1(V3 = "") -> ()
| _ -> ()

let (Case1(V4 = z)) = y
let (Case1(V4 = z)) = y

let z a = Some ("", "", a = "")
1 change: 1 addition & 0 deletions tests/FSharp.Compiler.ComponentTests/Conformance/UnionTypes/UnionTypes.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ module UnionTypes =
(Error 3174, Line 14, Col 9, Line 14, Col 11, "The union case 'Case1' does not have a field named 'V3'.")
(Warning 26, Line 15, Col 3, Line 15, Col 10, "This rule will never be matched")
(Error 3174, Line 17, Col 12, Line 17, Col 14, "The union case 'Case1' does not have a field named 'V4'.")
(Error 3174, Line 19, Col 25, Line 19, Col 26, "The union case 'Some' does not have a field named 'a'.")
]

//SOURCE=E_UnionFieldConflictingName.fs SCFLAGS="--test:ErrorRanges" # E_UnionFieldConflictingName.fs
Expand Down