Hide Obsolete warnings on record initializer not using the obsolete field #14195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should this also behind a preview flag ? |
Contributor
|
I'm OK with considering this a bug fix, |
…-not-using-the-obsolete-field # Conflicts: # tests/FSharp.Compiler.ComponentTests/Language/ObsoleteAttributeCheckingTests.fs
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
Contributor
Author
|
@vzarytovskii I'm a little stuck here. Would appreciate some pointers or if you are willing to take this over will be also fine by me. I do not want to hold this from being fixed. |
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
vzarytovskii
reviewed
Feb 1, 2023
| | SynTupleTypeSegment.Slash _ :: SynTupleTypeSegment.Type ty :: args -> | ||
| let ms1, tpenv = TcMeasure cenv newOk checkConstraints occ env tpenv ty m | ||
| gather args tpenv (Measure.Prod(acc, Measure.Inv ms1)) | ||
| | _ -> failwith "inpossible" |
Member
There was a problem hiding this comment.
Aw, I liked the "inpossible" more!
…the-obsolete-field' of https://github.com/edgarfgp/fsharp into pr/14195
Member
|
In the code added by this PR, BuildFieldMap tries to bring fields from inner expressions to the outer type in case of a double-nested record update.
|
…-not-using-the-obsolete-field
…-not-using-the-obsolete-field
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to Fix #14203