Skip to content

Use a more accurate range when reporting an error on delegate type declaration #14208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
T-Gro merged 3 commits into from
Nov 3, 2022
Merged

Use a more accurate range when reporting an error on delegate type declaration #14208

T-Gro merged 3 commits into from
Nov 3, 2022
+11 −13

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Nov 1, 2022 •
edited
Loading

This PR improves one on first contribution to F# #13078 by:

  • Using a more accurate range showing exactly the error occurs (parenthesis, and arguments)
  • This will allow to use the quick fix (Remove argument from constructors in case of an error)
  • Remove duplicated tests that were not use in any env.lst

@edgarfgp edgarfgp requested a review from a team as a code owner November 1, 2022 15:00
@edgarfgp edgarfgp changed the title Use more a more accurate range when reporting an error on delegate type declaration Use a more accurate range when reporting an error on delegate type declaration Nov 1, 2022
@T-Gro T-Gro merged commit 9d82592 into dotnet:main Nov 3, 2022
@allisonchou allisonchou mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.5

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edgarfgp @0101 @T-Gro @vzarytovskii