Skip to content

Add GetSetKeyword to trivia #14214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vzarytovskii merged 10 commits into from
Nov 4, 2022
Merged

Add GetSetKeyword to trivia #14214

vzarytovskii merged 10 commits into from
Nov 4, 2022

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Nov 2, 2022

Add get, set range to SynMemberSig.Member, SynMemberDefn.AbstractSlot & SynMemberSig.Member.

@nojaf nojaf requested a review from a team as a code owner November 2, 2022 13:24
T-Gro
T-Gro requested changes Nov 2, 2022
View reviewed changes
@T-Gro T-Gro self-requested a review November 3, 2022 10:49
@T-Gro T-Gro requested review from 0101, dsyme and vzarytovskii November 3, 2022 19:15
@nojaf
Copy link
Contributor Author

nojaf commented Nov 4, 2022

@vzarytovskii is there some sort of command thing I can enter (like azp run or something similar) to just re-run the failed jobs?
I get this on a weekly bases, there is nothing really wrong with my code but one of the builds fails due to reasons beyond my control.

In this case Unhandled Exception: System.IO.IsolatedStorage.IsolatedStorageException: Unable to create the store directory. happened.

@vzarytovskii
Copy link
Member

vzarytovskii commented Nov 4, 2022

@vzarytovskii is there some sort of command thing I can enter (like azp run or something similar) to just re-run the failed jobs?
I get this on a weekly bases, there is nothing really wrong with my code but one of the builds fails due to reasons beyond my control.

In this case Unhandled Exception: System.IO.IsolatedStorage.IsolatedStorageException: Unable to create the store directory. happened.

I don't think there's now. I can look if we can so something

@T-Gro
Copy link
Member

T-Gro commented Nov 4, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 4, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@vzarytovskii vzarytovskii merged commit 70499ce into dotnet:main Nov 4, 2022
@allisonchou allisonchou mentioned this pull request Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

@dsyme dsyme Awaiting requested review from dsyme

@0101 0101 Awaiting requested review from 0101

Assignees

No one assigned

Labels

release/17.5

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nojaf @vzarytovskii @T-Gro