Skip to content

Conversation

@T-Gro
Copy link
Member

@T-Gro T-Gro commented Dec 22, 2022

This bug has been fixed in the meantime.
Original issue:
F#: #5910
Runtime: dotnet/runtime#11488

Resolution in runtime repo:
dotnet/coreclr#21368

Tests:
image

@T-Gro T-Gro requested a review from a team as a code owner December 22, 2022 14:11
@vzarytovskii
Copy link
Member

vzarytovskii commented Dec 27, 2022

So, what happens if FSharp.Core with this change is loaded into runtime with bug present? Or was the fix backported to all branches?

@T-Gro
Copy link
Member Author

T-Gro commented Dec 27, 2022

So, what happens if FSharp.Core with this change is loaded into runtime with bug present? Or was the fix backported to all branches?

The worst case is that repeated access to .Current after enumeration has finished (MoveNext() returned false) will not throw.

I tried searching trough the runtime repo, but I do not see links which would tell me which versions this went into.
I can only see it is a little over 4 years ago since it was merged to main.
dotnet/coreclr#21368

@T-Gro
Copy link
Member Author

T-Gro commented Dec 27, 2022

But since it was 4 years ago, it means that versions 6 and 7 have it (the only supported versions as of now?).

@T-Gro T-Gro merged commit 73c9074 into main Jan 5, 2023
@T-Gro T-Gro deleted the dictionary-impl-enumerable-via-SZGenericEnumerators branch January 5, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants