Skip to content

Preview features telemetry #14896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 1 commit into from
Mar 14, 2023
Merged

Preview features telemetry #14896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ type internal FSharpWorkspaceServiceFactory
| _ ->
let checker =
lazy
TelemetryReporter.reportEvent "languageservicestarted" []

let editorOptions =
let editorOptions = workspace.Services.GetService<EditorOptions>()

Expand All @@ -128,6 +126,18 @@ type internal FSharpWorkspaceServiceFactory
let useSyntaxTreeCache =
getOption (fun options -> options.LanguageServicePerformance.UseSyntaxTreeCache) LanguageServicePerformanceOptions.Default.UseSyntaxTreeCache

let enableInMemoryCrossProjectReferences =
getOption (fun options -> options.LanguageServicePerformance.EnableInMemoryCrossProjectReferences) false

let enableFastFindReferences =
getOption (fun options -> options.LanguageServicePerformance.EnableFastFindReferences) false

let isInlineParameterNameHintsEnabled =
getOption (fun options -> options.Advanced.IsInlineParameterNameHintsEnabled) false

let isInlineTypeHintsEnabled =
getOption (fun options -> options.Advanced.IsInlineTypeHintsEnabled) false

let checker =
FSharpChecker.Create(
projectCacheSize = 5000, // We do not care how big the cache is. VS will actually tell FCS to clear caches, so this is fine.
Expand All @@ -142,6 +152,16 @@ type internal FSharpWorkspaceServiceFactory
documentSource = (if enableLiveBuffers then DocumentSource.Custom getSource else DocumentSource.FileSystem),
useSyntaxTreeCache = useSyntaxTreeCache)

TelemetryReporter.reportEvent "languageservicestarted" [
nameof enableLiveBuffers, enableLiveBuffers
nameof useSyntaxTreeCache, useSyntaxTreeCache
nameof enableParallelReferenceResolution, enableParallelReferenceResolution
nameof enableInMemoryCrossProjectReferences, enableInMemoryCrossProjectReferences
nameof enableFastFindReferences, enableFastFindReferences
nameof isInlineParameterNameHintsEnabled, isInlineParameterNameHintsEnabled
nameof isInlineTypeHintsEnabled, isInlineTypeHintsEnabled
]

if enableLiveBuffers then
workspace.WorkspaceChanged.Add(fun args ->
if args.DocumentId <> null then
Expand Down
20 changes: 15 additions & 5 deletions vsintegration/src/FSharp.Editor/LanguageService/SymbolHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ open Microsoft.CodeAnalysis.Text
open FSharp.Compiler.CodeAnalysis
open FSharp.Compiler.Symbols
open FSharp.Compiler.Text
open Microsoft.VisualStudio.FSharp.Editor.Symbols
open Microsoft.VisualStudio.FSharp.Editor.Symbols
open Microsoft.VisualStudio.FSharp.Editor.Telemetry

module internal SymbolHelpers =
/// Used for local code fixes in a document, e.g. to rename local parameters
Expand All @@ -37,10 +38,19 @@ module internal SymbolHelpers =
}

let getSymbolUsesInProjects (symbol: FSharpSymbol, projects: Project list, onFound: Document -> TextSpan -> range -> Async<unit>, ct: CancellationToken) =
projects
|> Seq.map (fun project ->
Task.Run(fun () -> project.FindFSharpReferencesAsync(symbol, onFound, "getSymbolUsesInProjects", ct)))
|> Task.WhenAll
match projects with
| [] -> Task.CompletedTask
| firstProject::_ ->
let isFastFindReferencesEnabled = firstProject.IsFastFindReferencesEnabled
let props = [ nameof isFastFindReferencesEnabled, isFastFindReferencesEnabled :> obj ]
backgroundTask {
TelemetryReporter.reportEvent "getSymbolUsesInProjectsStarted" props
do! projects
|> Seq.map (fun project ->
Task.Run(fun () -> project.FindFSharpReferencesAsync(symbol, onFound, "getSymbolUsesInProjects", ct)))
|> Task.WhenAll
TelemetryReporter.reportEvent "getSymbolUsesInProjectsFinished" props
}

let getSymbolUsesInSolution (symbol: FSharpSymbol, declLoc: SymbolDeclarationLocation, checkFileResults: FSharpCheckFileResults, solution: Solution, ct: CancellationToken) =
async {
Expand Down