Write compilation references and compilation options to PDBs#14981
Draft
baronfel wants to merge 6 commits intodotnet:mainfrom
Draft
Write compilation references and compilation options to PDBs#14981baronfel wants to merge 6 commits intodotnet:mainfrom
baronfel wants to merge 6 commits intodotnet:mainfrom
Conversation
Member
|
Test framework will probably also need to be extended, to check those: fsharp/tests/FSharp.Test.Utilities/Compiler.fs Lines 1210 to 1215 in 3d4eb5c Example for sequence points: fsharp/tests/FSharp.Test.Utilities/Compiler.fs Lines 1151 to 1161 in 3d4eb5c And import tables: fsharp/tests/FSharp.Test.Utilities/Compiler.fs Lines 1117 to 1149 in 3d4eb5c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12002
This writes the Compilation Metadata References and Compilation Options tables to the CustomDebugInformation area of the PDB. There are a number of TODOs, and I'm not 100% sure I'm getting the actual information we will want to get a real end-to-end setup.
With these changes, we look like other .NET assemblies!
What this should do immediately is allow VS-based tooling to synthesize MetadataReferences from this cached data, so that go-to-def for sourcelinked files has a matching set of assembly references to do typechecking against (and therefore light up IDE tooling).
There are a number of TODOs that I'd like to get some feedback on. I'm fairly sure I'm reading required data correctly, but I want to make sure the sources I'm pulling it from are correct.
Also I'm certain I'm missing a number of compiler options that would be necessary to have on the read-side of this to ensure 1:1 compilation.
Finally, I haven't done the step that would map from the compilation options + compilation references to a proper FSharpProjectOptions - that would probably need to be done to show a true end-to-end in an editor.
I would love any and all review/pointers for the next steps here.