Aot for static linked fsharpcore test and fix duplicated embedded types issue. #15168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
aotforstaticlinkedfsharpcore
branch
5 times, most recently
from
7e5bc19 to
bd39e29
Compare
KevinRansom
force-pushed
the
aotforstaticlinkedfsharpcore
branch
from
971d337 to
6f1a703
Compare
KevinRansom
changed the title
abonie
reviewed
May 12, 2023
abonie
approved these changes
May 12, 2023
KevinRansom
force-pushed
the
aotforstaticlinkedfsharpcore
branch
from
ea5f0d3 to
85b5f33
Compare
T-Gro
reviewed
May 16, 2023
tests/AheadOfTime/Trimming/SelfContained_Trimming_Test/SelfContained_Trimming_Test.fsproj
Show resolved
Hide resolved
T-Gro
reviewed
May 16, 2023
...me/Trimming/StaticLinkedFSharpCore_Trimming_Test/StaticLinkedFSharpCore_Trimming_Test.fsproj
Outdated
Show resolved
Hide resolved
T-Gro
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #15167
Shows up in virtually all static link scenarios.
When static linking assemblies targetting net472 or netstandard2.0, or net5 and below I suppose. StaticLinking will try to copy the:
to the built library, obviously this will cause duplicates in the built library which causes a compile error. This change will stop them being copied more than once to the output directory. This is limited to the known set of embeddable attributes, if additional attributes become embeddable in the future the known set list needs to be updated.
As part of this PR we also update the AOT tests to include static linking scenarios:
And wire up static linking a bit better in the componenttests framework as well as add a static linking test to the component tests.