Skip to content

Fix explicit size for struct DUs #15183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vzarytovskii merged 2 commits into from
May 4, 2023
Merged

Fix explicit size for struct DUs #15183

vzarytovskii merged 2 commits into from
May 4, 2023

Conversation

@vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented May 3, 2023

Fixes #15174

@vzarytovskii vzarytovskii requested a review from a team as a code owner May 3, 2023 14:37
@vzarytovskii vzarytovskii enabled auto-merge (squash) May 4, 2023 11:46
@vzarytovskii
Copy link
Member Author

vzarytovskii commented May 4, 2023

@dotnet/fsharp-team-msft this is ready

@vzarytovskii vzarytovskii merged commit d1237f8 into dotnet:main May 4, 2023
@allisonchou allisonchou mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

release/17.7

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

F# gives important structs explicit size causing coreclr to pessimize codegen for them

3 participants

@vzarytovskii @dsyme @T-Gro