Skip to content

[main] Update dependencies from dotnet/arcade #15204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dotnet-maestro wants to merge 8 commits into from
Closed

[main] Update dependencies from dotnet/arcade #15204

dotnet-maestro wants to merge 8 commits into from

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 10, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: d1dd3c14-f8e9-46f4-7fb7-08d8446de174
  • Build: 20230515.1
  • Date Produced: May 15, 2023 1:54:05 PM UTC
  • Commit: 2d8d59065b5e090584a8e90c4371fc06ed60bdc5
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
b1e8ac6 
…509.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23259.5
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 10, 2023 12:03
KevinRansom
KevinRansom suggested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment •
edited by vzarytovskii
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want dotnet 8 in main, it's updated in 17.7.

@vzarytovskii vzarytovskii changed the base branch from main to release/dev17.7 May 10, 2023 17:16
dotnet-maestro bot and others added 6 commits May 11, 2023 12:03
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
70fec90 
…510.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23260.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
2896712 
…511.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23261.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
0491d08 
…512.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23262.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
e0067c5 
…515.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23265.1
@vzarytovskii
Merge branch 'release/dev17.7' into darc-main-959e5c32-3aab-49cf-8ca9…
33381c5 
…-65c0272da272
@vzarytovskii
Update Version.Details.xml
dde5d92
@vzarytovskii vzarytovskii changed the base branch from release/dev17.7 to release/net8 May 24, 2023 11:01
@vzarytovskii vzarytovskii mentioned this pull request May 24, 2023
Merged
@mmitche
Copy link
Member

mmitche commented Jun 5, 2023

Changing the base branch here isn't recommended. The arcade subscription should be retargeted to the net8 branch

@vzarytovskii
Copy link
Member

vzarytovskii commented Jun 5, 2023 •
edited
Loading

Changing the base branch here isn't recommended. The arcade subscription should be retargeted to the net8 branch

Could you please point me where should it be changed? We probably want it for net8 for now.

@mmitche
Copy link
Member

mmitche commented Jun 5, 2023 

PS C:\r\dotnet-release> darc get-subscriptions --source-repo arcade --target-repo fsharp
https://github.com/dotnet/arcade (.NET Eng - Latest) ==> 'https://github.com/dotnet/fsharp' ('main')
  - Id: d1dd3c14-f8e9-46f4-7fb7-08d8446de174
  - Update Frequency: EveryDay
  - Enabled: True
  - Batchable: False
  - PR Failure Notification tags:
  - Merge Policies:
    Standard
  - Last Build: 20230505.2 (5dff25b814b90abb85c847ed274cf4afb2c1b276)

This subscription would be deleted, then recreated targeting release/net8. I've done so.

@vzarytovskii
Copy link
Member

vzarytovskii commented Jun 6, 2023

Going to close this one then, thanks, Matt!

@T-Gro T-Gro deleted the darc-main-959e5c32-3aab-49cf-8ca9-65c0272da272 branch August 3, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KevinRansom KevinRansom KevinRansom requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmitche @vzarytovskii @KevinRansom