Fix intellisense in WebApi projects #15228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitTool.Version nuget package sets the language version to C# if it hasn't been set ...
https://github.com/GitTools/GitVersion/blob/28ce1b4f5ea8d1337485b8ca9d01c80fb4c94e6d/src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.props#L7
This breaks the design time build because now it thinks it's handling C# files and so calls build targets that aren't even loaded in an F# design time build. This change allows us to specify that it is an F# project at our first chance, w/o fixing in the dotnet sdk itself, because afer all if it is loading F# props and targets, it for sure is an F# project.
It would be good, if the owners of Gittool.Version could properly fix their package, to not set the Language property, they can always update their code to handle a not set Language, without impacting all subsequent imported props and targets.
Error:
Fixed:
