Skip to content

Deferencing only once per function call for RangeEnumerator #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 1 commit into from
Sep 20, 2016
Merged

Deferencing only once per function call for RangeEnumerator #1532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/fsharp/FSharp.Core/prim-types.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5324,12 +5324,13 @@ namespace Microsoft.FSharp.Core
// is undefined prior to the first call of MoveNext and post called to MoveNext
// that return false (see https://msdn.microsoft.com/en-us/library/58e146b7%28v=vs.110%29.aspx)
// so we should be able to just return value here, which would be faster
if !value < n then
let derefValue = !value
if derefValue < n then
notStarted ()
elif !value > m then
elif derefValue > m then
alreadyFinished ()
else
!value
derefValue

{ new IEnumerator<'T> with
member __.Dispose () = ()
Expand All @@ -5339,11 +5340,12 @@ namespace Microsoft.FSharp.Core
member __.Current = box (current ())
member __.Reset () = value := n - LanguagePrimitives.GenericOne
member __.MoveNext () =
if !value < m then
value := !value + LanguagePrimitives.GenericOne
let derefValue = !value
if derefValue < m then
value := derefValue + LanguagePrimitives.GenericOne
true
elif !value = m then
value := m + LanguagePrimitives.GenericOne
elif derefValue = m then
value := derefValue + LanguagePrimitives.GenericOne
false
else false }

Expand Down