-
Notifications
You must be signed in to change notification settings - Fork 847
Wrap hash postfix type in parentheses. #15355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fd07ac3
Wrap hash postfix type in parentheses.
nojaf 474a518
Only add parentheses if there are any typeInstantiations.
nojaf 43ec6a3
Merge branch 'main' into hash-contraint-seq-fix
nojaf 94936fb
Trigger CI
nojaf 79bb363
Merge branch 'hash-contraint-seq-fix' of https://github.com/nojaf/fsh…
nojaf 55d91ae
Merge branch 'main' into hash-contraint-seq-fix
nojaf e6a7326
Update module names.
nojaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module Signatures.SignatureTests | ||
| module Signatures.ArrayTests | ||
|
|
||
| open Xunit | ||
| open Signatures.TestHelpers | ||
|
|
||
33 changes: 33 additions & 0 deletions
33
tests/FSharp.Compiler.ComponentTests/Signatures/HashConstraintTests.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| module Signatures.HashConstraintTests | ||
|
|
||
| open Xunit | ||
| open FsUnit | ||
| open FSharp.Test.Compiler | ||
| open Signatures.TestHelpers | ||
|
|
||
| [<Fact>] | ||
| let ``Optional hash constraint`` () = | ||
| FSharp | ||
| """ | ||
| module Foo | ||
|
|
||
| [<Interface>] | ||
| type Node = | ||
| abstract Children: int array | ||
|
|
||
| let noa<'n when 'n :> Node> (n: 'n option) = | ||
| match n with | ||
| | None -> Array.empty | ||
| | Some n -> [| n :> Node |] | ||
| """ | ||
| |> printSignatures | ||
| |> should | ||
| equal | ||
| """ | ||
| module Foo | ||
|
|
||
| type Node = | ||
|
|
||
| abstract Children: int array | ||
|
|
||
| val noa: n: #Node option -> Node array""" | ||
2 changes: 1 addition & 1 deletion
2
tests/FSharp.Compiler.ComponentTests/Signatures/MissingDiagnostic.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...ompiler.ComponentTests/Signatures/TestCasesForGenerationRoundTrip/hash_constraint_seq.fsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| module Foo | ||
|
|
||
| open System | ||
| open System.Threading.Tasks | ||
|
|
||
| let mapWithAdditionalDependenies | ||
| (mapping: 'a -> 'b * #seq<#IDisposable>) = 0 | ||
nojaf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.