Fix duplicate find references results #15728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15191
The problem is that if a project has multiple target frameworks (such as
<TargetFrameworks>net472;net7.0</TargetFrameworks>) it creates multiple projects in Roslyn'sSolutionwhich all contain the document in which our symbol is defined.We now report all definition locations, this PR adds a
distinctBy (Document.FilePath, Project.FilePath)for the definitions. We still report all references even if they're duplicate (even though they don't have to be if there are #ifdefs) but VS handles it correctly when we assign them to the same definition item.Not sure how to write tests for it 🫤