Add warning for interpolated strings where type is not given #15747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant2002
force-pushed
the
kant/typed-string-warn
branch
from
b2c4fcc to
196a187
Compare
By default warning is off. fsharp/fslang-suggestions#1285 (comment)
kant2002
force-pushed
the
kant/typed-string-warn
branch
from
196a187 to
f57d1e3
Compare
T-Gro
approved these changes
Aug 4, 2023
vzarytovskii
approved these changes
Aug 4, 2023
0101
reviewed
Aug 4, 2023
| 3577,tcOverrideUsesMultipleArgumentsInsteadOfTuple,"This override takes a tuple instead of multiple arguments. Try to add an additional layer of parentheses at the method definition (e.g. 'member _.Foo((x, y))'), or remove parentheses at the abstract method declaration (e.g. 'abstract member Foo: 'a * 'b -> 'c')." | ||
| featureUnmanagedConstraintCsharpInterop,"Interop between C#'s and F#'s unmanaged generic constraint (emit additional modreq)" | ||
| 3578,chkCopyUpdateSyntaxInAnonRecords,"This expression is an anonymous record, use {{|...|}} instead of {{...}}." | ||
| 3579,alwaysUseTypedStringInterpolation,"Prefer to use typed interpolated strings over untyped one." |
Contributor
There was a problem hiding this comment.
Not sure about this message. Maybe something like this would be a bit better?
Suggested change
| 3579,alwaysUseTypedStringInterpolation,"Prefer to use typed interpolated strings over untyped one." | |
| 3579,alwaysUseTypedStringInterpolation,"Consider using typed interpolated strings over untyped ones." |
or
Suggested change
| 3579,alwaysUseTypedStringInterpolation,"Prefer to use typed interpolated strings over untyped one." | |
| 3579,alwaysUseTypedStringInterpolation,"Consider adding type identifiers to the interpolated string." |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default warning is off.
fsharp/fslang-suggestions#1285 (comment)