Skip to content

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Aug 7, 2023

  • Check that all assertions are correct
  • Remove the old tests once the team and CI are happy

This will help with #15733 as I can run the pattern matching tests easily

@edgarfgp edgarfgp requested a review from a team as a code owner August 7, 2023 19:20
@KevinRansom
Copy link
Contributor

Nice!!!!!!

@psfinaki
Copy link
Contributor

psfinaki commented Aug 8, 2023

Thanks Edgar, thanks for investing in our testing life :)
Hopefully git will handle moved files so that we can review it more or less thoroughly.

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Aug 8, 2023

Thanks Edgar, thanks for investing in our testing life :) Hopefully git will handle moved files so that we can review it more or less thoroughly.

Removed the old test. Let's see how it handles the moved files.

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 11, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants