Parens: Keep parens in method calls in dot-lambdas #16395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Noooo on the contrary, thanks for doing this in small chunks, there is nothing better than small PRs :D |
psfinaki
approved these changes
Dec 6, 2023
vzarytovskii
approved these changes
Dec 7, 2023
auto-merge was automatically disabled
December 7, 2023 14:24
Head branch was pushed to by a user without write access
Contributor
Author
Contributor
|
Nope, that's good to go. Thanks for the ping, let get this in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another followup to #16079.
Description
Keep parentheses in method calls in dot-lambdas, e.g.:
Checklist
@psfinaki Sorry for flooding you with these PRs... These are just quick things I'm coming across by chance. Once these are merged, I'll open one to move the
UnnecessaryParenthesesmodule out ofServiceAnalysis.fsto its own file. I hope to have a PR for the tests after that...