Skip to content

Conversation

@vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Dec 7, 2023

Added tools I use the most. Now I need to manually install them in dev container every time, this will allow installing them in one command.

Also, added a task to launch fsi/fsc under trace, so it can be opened with speedscope later.

@vzarytovskii vzarytovskii requested a review from a team as a code owner December 7, 2023 16:25
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful - how about we mention some of those tasks in the DEVGUIDE?

@vzarytovskii
Copy link
Member Author

vzarytovskii commented Dec 8, 2023

This looks useful - how about we mention some of those tasks in the DEVGUIDE?

Probably not worth it? These are standard tools/tasks, you either use them or don't. I feel like all of them are self explanatory?

We don't mention how to launch with VS diagnostic tools or dotTrace/dotMemory/windbg there.

@psfinaki
Copy link
Contributor

psfinaki commented Dec 8, 2023

Probably not worth it? These are standard tools/tasks, you either use them or don't. I feel like all of them are self explanatory?
We don't mention how to launch with VS diagnostic tools or dotTrace/dotMemory/windbg there.

Mmm e.g. we have that note about updating XLFs and it says "This can be done automatically by running this command" and I just thought we could add smth like "... or by executing this task in VSCode". So that people have a notion of those.

I personally don't use VSCode tasks so I don't know - but now looking at the PR I am thinking it is easy enough to give them a try and change my dev routines.

Up to you ofc.

@vzarytovskii
Copy link
Member Author

Probably not worth it? These are standard tools/tasks, you either use them or don't. I feel like all of them are self explanatory?
We don't mention how to launch with VS diagnostic tools or dotTrace/dotMemory/windbg there.

Mmm e.g. we have that note about updating XLFs and it says "This can be done automatically by running this command" and I just thought we could add smth like "... or by executing this task in VSCode". So that people have a notion of those.

I personally don't use VSCode tasks so I don't know - but now looking at the PR I am thinking it is easy enough to give them a try and change my dev routines.

Up to you ofc.

I wouldn't update them just for now. Since our VSCode support is not great at the moment. I'd update it and fully add once we do more LSP testing, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants