Fix inlining regression #17201
Merged
Fix inlining regression #17201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
added
NO_RELEASE_NOTES
Contributor
|
Caution Repository is on lockdown for maintenance, all merges are on hold. |
Contributor
|
baronfel
changed the title
KevinRansom
approved these changes
May 21, 2024
abonie
approved these changes
May 21, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent feature impacting the IL Visibility of some F# types had an unintended impact to the F# optimization feature. The optimizer is incorrectly unable to inline some code that has "private" visibility, even when the inlined variables are "in-scope". The fix removes the code that aggressively and incorrectly detects this private visibility.
Regression? (was it working in a previous release or preview?)
Yes
this is a regression, it has been observed internally, as well as by external developers using the 8.0.300 preview SDK.
Risk (see taxonomy)
Low: it removes an unnecessary, incorrect warning.
Testing
New automated regression tests added.
Original issue: #17161
PR into main: 9d05359